From 800f65a5e65d0d2a86a8d0fbc422dcce05f87b3c Mon Sep 17 00:00:00 2001
From: Vojtech Mares <iam@vojtechmares.com>
Date: Tue, 4 Jul 2023 20:44:25 +0200
Subject: [PATCH] refactor(helm): do not specify Job .spec.selector (bast
 practice)

See: https://kubernetes.io/docs/concepts/workloads/controllers/job/#specifying-your-own-pod-selector
---
 charts/backoffice/templates/job-db-migration.yaml | 5 -----
 charts/backoffice/templates/job-db-seed.yaml      | 5 -----
 2 files changed, 10 deletions(-)

diff --git a/charts/backoffice/templates/job-db-migration.yaml b/charts/backoffice/templates/job-db-migration.yaml
index ece4df6..7f703f8 100644
--- a/charts/backoffice/templates/job-db-migration.yaml
+++ b/charts/backoffice/templates/job-db-migration.yaml
@@ -14,11 +14,6 @@ spec:
   backoffLimit: 0
   ttlSecondsAfterFinished: 86400 # 1 day
   activeDeadlineSeconds: 120 # 2 minutes
-  selector:
-    matchLabels:
-      app.kubernetes.io/name: {{ .Chart.Name }}
-      app.kubernetes.io/instance: {{ .Release.Name }}
-      app.kubernetes.io/component: database-migration
   template:
     spec:
       {{- if .Values.dockerconfigjsonBase64 }}
diff --git a/charts/backoffice/templates/job-db-seed.yaml b/charts/backoffice/templates/job-db-seed.yaml
index 938a3d0..cdcf43d 100644
--- a/charts/backoffice/templates/job-db-seed.yaml
+++ b/charts/backoffice/templates/job-db-seed.yaml
@@ -14,11 +14,6 @@ spec:
   backoffLimit: 0
   ttlSecondsAfterFinished: 86400 # 1 day
   activeDeadlineSeconds: 120 # 2 minutes
-  selector:
-    matchLabels:
-      app.kubernetes.io/name: {{ .Chart.Name }}
-      app.kubernetes.io/instance: {{ .Release.Name }}
-      app.kubernetes.io/component: database-seed
   template:
     spec:
       {{- if .Values.dockerconfigjsonBase64 }}