refactor(deploy): use external (hand-made) image pull secret

deploy/templates/_helpers.tpl

@@ -1,5 +0,0 @@
-{{- define "imagePullSecret" }}
-{{- with .Values.imageCredentials }}
-{{- printf "{\"auths\":{\"%s\":{\"username\":\"%s\",\"password\":\"%s\",\"email\":\"%s\",\"auth\":\"%s\"}}}" .registry .username .password .email (printf "%s:%s" .username .password | b64enc) | b64enc }}
-{{- end }}
-{{- end }}

deploy/templates/deployment.yaml

@@ -29,8 +29,10 @@ spec:
         app.kubernetes.io/component: "backend-api"
     spec:
       automountServiceAccountToken: false
+      {{- with .Values.image.pullSecrets }}
       imagePullSecrets:
-        - name: {{ .Release.Name }}-pull-secret
+        {{ toYaml . | nindent 8 }}
+      {{- end }}
       containers:
         - name: {{ .Chart.Name }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"

deploy/templates/image-pull-secret.yaml

@@ -1,11 +0,0 @@
-apiVersion: v1
-kind: Secret
-metadata:
-  name: {{ .Release.Name }}-pull-secret
-  annotations:
-    "helm.sh/hook": pre-install
-    "helm.sh/hook-weight": "-99"
-    "helm.sh/hook-delete-policy": before-hook-creation
-type: kubernetes.io/dockerconfigjson
-data:
-  .dockerconfigjson: {{ template "imagePullSecret" . }}

deploy/values.staging.yaml

@@ -5,3 +5,7 @@ ingress:
     cert-manager.io/cluster-issuer: letsencrypt-dns-production
 
 replicas: 2
+
+image:
+  pullSecrets:
+    - name: mareshq-gitlab-registry

deploy/values.yaml

@@ -1,15 +1,10 @@
 replicas: 1
 
 image:
+  pullSecrets: []
   repository: registry.mareshq.com/hq/yggdrasil/httpserver
   tag: latest
 
-imageCredentials:
-  registry: registry.mareshq.com
-  email: nobody@mareshq.com
-  username: someone
-  password: sillyness
-
 ingress:
   enabled: false
   host: example.com